[logback-dev] [qos-ch/logback] cbd10a: defined executor service sizing constants in CoreC...

Carl Harris ceharris at vt.edu
Tue Apr 30 14:26:57 CEST 2013


  Branch: refs/heads/LOGBACK-849-alternative
  Home:   https://github.com/qos-ch/logback
  Commit: cbd10a44c2104e9d4681f50e1e59bfcf4496d178
      https://github.com/qos-ch/logback/commit/cbd10a44c2104e9d4681f50e1e59bfcf4496d178
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    M logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java

  Log Message:
  -----------
  defined executor service sizing constants in CoreConstants


  Commit: 1fd89398f32ac04a7a733b9dfef07f74198e76f0
      https://github.com/qos-ch/logback/commit/1fd89398f32ac04a7a733b9dfef07f74198e76f0
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    A logback-core/src/main/java/ch/qos/logback/core/util/ExecutorServiceUtil.java

  Log Message:
  -----------
  added ExecutorServiceUtil for executor creation and shutdown

This will allow logback-core and logback-access to both use the same
executor configuration and shutdown logic.


  Commit: ef128dfdce3814f1d7e324399f11b69e6dc819b5
      https://github.com/qos-ch/logback/commit/ef128dfdce3814f1d7e324399f11b69e6dc819b5
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    M logback-core/src/main/java/ch/qos/logback/core/ContextBase.java

  Log Message:
  -----------
  added LifeCycle methods and lazy executor service init to ContextBase

Since ContextBase has never before implemented LifeCycle, there are lots
of existing uses (in tests) that would need to be modified if calling
the LifeCycle methods is made a strict requirement.  By using a lazy
initialization of executor service, we can allow existing uses to ignore
the lifecycle methods, and focus our attention on those few cases where
it calling the stop method really matters.


  Commit: a66da9c5bf3ce1f6f840bb24a61b6902956bdc8e
      https://github.com/qos-ch/logback/commit/a66da9c5bf3ce1f6f840bb24a61b6902956bdc8e
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    M logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java

  Log Message:
  -----------
  modified LoggerContext to call super.start and super.stop


  Commit: 805ba451da187d14414204f37ff3dbaf98413ca2
      https://github.com/qos-ch/logback/commit/805ba451da187d14414204f37ff3dbaf98413ca2
  Author: Carl Harris <ceharris at vt.edu>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    M logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java

  Log Message:
  -----------
  modified LogbackValve to use ExecutorServiceUtil

Previously, the executor service used here was not consistent with a
recent change to ContextBase (to allow more than one concurrent
asynchronous task).  This commit also ensures that the executor service
is shut down when the valve is stopped.


Compare: https://github.com/qos-ch/logback/compare/cbd10a44c210^...805ba451da18


More information about the logback-dev mailing list