[logback-dev] [qos-ch/logback] 841d22: Be extra lenient for non-Sun JDK perf tests

Tony Trinh tony19 at gmail.com
Sat Sep 14 09:22:02 CEST 2013


  Branch: refs/heads/master
  Home:   https://github.com/qos-ch/logback
  Commit: 841d22aea4232777ad57d8174341495c792a4d7e
      https://github.com/qos-ch/logback/commit/841d22aea4232777ad57d8174341495c792a4d7e
  Author: Tony Trinh <tony19 at gmail.com>
  Date:   2013-09-13 (Fri, 13 Sep 2013)

  Changed paths:
    M logback-classic/src/test/java/ch/qos/logback/classic/spi/PackagingDataCalculatorTest.java

  Log Message:
  -----------
  Be extra lenient for non-Sun JDK perf tests

The slack factor for non-Sun JDK performance test in PackagingDataCalculatorTest
was not lenient enough for the small virtual nodes on Cloudbees Jenkins.
Some people were also reporting test failures here by a few percentage points
(on their slow development machines).

Bump slack factor from 10 to 15


  Commit: 409ba25961d40b4a6f7268ea596190a1abd4b935
      https://github.com/qos-ch/logback/commit/409ba25961d40b4a6f7268ea596190a1abd4b935
  Author: Tony Trinh <tony19 at gmail.com>
  Date:   2013-09-14 (Sat, 14 Sep 2013)

  Changed paths:
    M logback-core/src/test/java/ch/qos/logback/core/recovery/RecoveryCoordinatorTest.java

  Log Message:
  -----------
  Fix RecoveryCoordinatorTest

Use new instance of RecoveryCoordinator in each test. Otherwise, the timestamp
of the next call to isTooSoon() could happen well after the backoff threshold
on slow machines (such as small nodes on Cloudbees Jenkins), causing false
test failures.

This also renames and refines the individual tests.


Compare: https://github.com/qos-ch/logback/compare/9ff887679130...409ba25961d4


More information about the logback-dev mailing list