[logback-dev] vote for extending the AbstractSocketAppender

[Sebastian Gröbler]

Hey Logback-Devs,

I recently developed an “FileBufferingSocketAppender” for the logback-android (see https://github.com/tony19/logback-android/pull/57) project in order to have a more robust SocketAppender implementation.
The appender basically buffers events to disk so in case of a crash or connection problem no events are being lost. This is especially an important feature for crash-reporting on android devices.
After some discussions with Tony we decided that it might make sense to put this Appender in either the logback, logback-contrib or logback-extension project and refer to it from the logback-android project, because the feature it self is not really specific to android.

The FileBufferingSocketAppender was initially developed before the AbstractSocketAppender got the internal queue to buffer events in memory. After some thinking I found that my FileBufferingSocketAppender is basically not much different to the most recent implementation of the AbstractSocketAppender.
The only difference is the way the events are being buffered (in-memory vs. on-disk), which I think could be configurable.

So I am asking the logback developers for their opinion:

Does it makes sense to make the queue implementation of the AbstractSocketAppender configurable? The default would stay the same, but the user would also be able to either provide his own implementation or choose between in-memory and on-disk.


Thanks for your time.
Sebastian


Btw. The mailman app gives a lot of errors during registration to the dev mailing list.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.qos.ch/pipermail/logback-dev/attachments/20140705/9967f5f6/attachment.html>