[logback-dev] [qos-ch/logback] b444c3: Make AccessEvent.prepareForDeferredProcessing() to...

Tony Trinh tony19 at gmail.com
Wed Jan 28 02:01:35 CET 2015


  Branch: refs/heads/master
  Home:   https://github.com/qos-ch/logback
  Commit: b444c3ffbf829a827a49908e553ea9414004dcdc
      https://github.com/qos-ch/logback/commit/b444c3ffbf829a827a49908e553ea9414004dcdc
  Author: Dmitry Andrianov <dimas at dataart.com>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java
    M logback-access/src/main/java/ch/qos/logback/access/spi/IAccessEvent.java
    M logback-access/src/test/java/ch/qos/logback/access/dummy/DummyRequest.java
    M logback-access/src/test/java/ch/qos/logback/access/spi/AccessEventSerializationTest.java

  Log Message:
  -----------
  Make AccessEvent.prepareForDeferredProcessing() to create a copy of the request attributes map so attributes are available later even if processing is done in a background thread.

Only Serializable attributes are copied to be on a safe side. Also, do not copy attributes set by Logback's TeeFilter as the very same information is already serialised as request/response content.


  Commit: 864c52e8650e130067bab45f7656e375b2c4716d
      https://github.com/qos-ch/logback/commit/864c52e8650e130067bab45f7656e375b2c4716d
  Author: Dmitry Andrianov <dimas at dataart.com>
  Date:   2015-01-25 (Sun, 25 Jan 2015)

  Changed paths:
    M logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java
    M logback-access/src/test/java/ch/qos/logback/access/dummy/DummyRequest.java
    M logback-access/src/test/java/ch/qos/logback/access/spi/AccessEventSerializationTest.java

  Log Message:
  -----------
  It was a mistake to use original httpRequest as long as it is available because web containers may recycle it and populate with the fields from another request. So make sure that when prepareForDeferredProcessing() is called, we will be only using copied data.


  Commit: 5909fcbb86702f4086131ba15cafec11efda51c4
      https://github.com/qos-ch/logback/commit/5909fcbb86702f4086131ba15cafec11efda51c4
  Author: Tony Trinh <tony19 at gmail.com>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java
    M logback-access/src/main/java/ch/qos/logback/access/spi/IAccessEvent.java
    M logback-access/src/test/java/ch/qos/logback/access/dummy/DummyRequest.java
    M logback-access/src/test/java/ch/qos/logback/access/spi/AccessEventSerializationTest.java

  Log Message:
  -----------
  Merge pull request #240 from dimas/master

Make AccessEvent.prepareForDeferredProcessing() to create a copy of the ...


Compare: https://github.com/qos-ch/logback/compare/db32b1ccddfd...5909fcbb8670


More information about the logback-dev mailing list