[logback-dev] [JIRA] Updates for LOGBACK-1659: Unnecessary OffsetDateTime creation in CachingDateFormat

QOS.CH (JIRA) noreply-jira at qos.ch
Sat Aug 13 16:43:00 CEST 2022

logback / LOGBACK-1659 [Open]
Unnecessary OffsetDateTime creation in CachingDateFormat


Here's what changed in this issue in the last few minutes.
This issue has been created
This issue is now assigned to you.

View or comment on issue using this link

 Issue created

Bertrand Renuart created this issue on 13/Aug/22 4:27 PM
Summary:              Unnecessary OffsetDateTime creation in CachingDateFormat
Issue Type:           Improvement
Affects Versions:     1.3.0-beta0
Assignee:             Logback dev list
Components:           logback-core
Created:              13/Aug/22 4:27 PM
Priority:             Major
Reporter:             Bertrand Renuart
  CachingDateFormat creates a temporary OffsetDateTime from the given instant to apply the configured time zone (see [here|https://github.com/qos-ch/logback/blob/master/logback-core/src/main/java/ch/qos/logback/core/util/CachingDateFormatter.java#L68-L69]) before passing it to the DateTimeFormatter for rendering.
  This temporary OffsetDateTime can be avoided by setting the ZoneId directly on the DateTimeFormatter when it is initialized. This is apparently what was foreseen in the constructor with the following [lines|https://github.com/qos-ch/logback/blob/master/logback-core/src/main/java/ch/qos/logback/core/util/CachingDateFormatter.java#L58]:
  public CachingDateFormatter(String pattern, ZoneId aZoneId) {
     dtf = DateTimeFormatter.ofPattern(pattern);
  Unfortunately this won't work because "{{withZone()}}" returns a new formatter which is not assigned to the "{{dtf}}" instance variable...
  *To summarise:*
  (1) In the constructor do something like:
  dtf = DateTimeFormatter.ofPattern(pattern).withZone(this.zoneId)
  (2) In the "format()" method do something like:
  Instant instant = Instant.ofEpochMilli(now);
  String result = dtf.format(instant);
  --> no need for an intermediate OffsetDateTime anymore

 This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

More information about the logback-dev mailing list