[logback-user] ShutdownHook WAS: Release of logback version 1.1.2

[Ceki Gulcu]

Just looked at the code of ShutdownHookAction. It looks good.

As for ContextBase.removeShutdownHook, after calling 
Runtime.getRuntime().removeShutdownHook(hook) you would also want to 
clear the hook associated with CoreConstants.SHUTDOWN_HOOK_THREAD.

Cheers,
--
Ceki

On 04.04.2014 08:38, Ceki Gulcu wrote:
> Hi Michael,
>
> Thank you for your message and my apologies for not responding sooner on
> this issue. Separating AsyncAppender and ShutdownHookAction would be
> nice but not strictly necessary. However, it would be easier to perform
> the merge after a rebase and a new pull request. Thank you for offering.
> Much appreciated.
>
> Best regards,
> --
> Ceki
>
>
> On 02.04.2014 22:47, Michael Reinhold wrote:
>> Hi Ceki,
>>
>> Glad to hear the next release of Logback is out!
>>
>> I apologize that I was not able to complete the changes for the
>> ShutdownHookAction and associated components prior to this release. I
>> did intend to have it ready for you to merge prior to 1.1.2 - clearly I
>> missed! I just wanted to reach out to you to find out how best to
>> proceed with getting the changes to AsyncAppender and the ShutdownHook
>> merged into logback.
>>
>> I'm assuming that you would prefer that I pull and rebase my work
>> against the latest commit in the repo? I'm not sure if I should close
>> the current pull request and initiate a new pull request? Would you
>> prefer that I split out the AsyncAppender changes into its own pull
>> request, separate from the ShutdownHookAction components? This probably
>> makes sense since the AsyncAppender timeout period is complete and
>> valuable to others even without a built-in Shutdown hook mechanism in
>> Logback.
>>
>> Please let me know how you would like me to proceed - I want to make
>> including these features as easy for the Logback team as possible!
>>
>> Regards,
>>
>> Mike Reinhold
>>
>>
>
>
> _______________________________________________
> Logback-user mailing list
> Logback-user at qos.ch
> http://mailman.qos.ch/mailman/listinfo/logback-user