[mistletoe] Source code

ceki ceki at qos.ch
Fri Apr 12 08:26:41 CEST 2013


Thank you for this patch. It appears that you have re-indented certain 
files. This makes it hard to track file changes. I am going to cherry 
pick the changes I can.

Please checkout the version found in HEAD (latest code from the repo) 
and test whether it works for you.

If I miss anything, please provide a new patch and please mind the 
indentation and the white space.

In the mean time I'll continue to prepare for release of version 0.3.

On 11.04.2013 23:18, Pierre Goupil wrote:
> Pull request done :-)
>
> Hope to hear from you, now.
>
> Regards,
>
> Pierre
>
>
> On Thu, Apr 11, 2013 at 10:39 PM, Pierre Goupil <goupilpierre at gmail.com
> <mailto:goupilpierre at gmail.com>> wrote:
>
>     Good catch! :-) One more problem left!
>
>
>     On Thu, Apr 11, 2013 at 10:36 PM, ceki <ceki at qos.ch
>     <mailto:ceki at qos.ch>> wrote:
>
>
>         I don't think MyAttributeModifier is being used anywhere.
>
>
>         On 11.04.2013 20:40, Pierre Goupil wrote:
>
>
>             In the class "MyAttributeModifier", this code is problematic
>             for me:
>
>                 @Override
>                 public void onComponentTag(final Component component, final
>             ComponentTag tag) {
>                   System.out.println("__ononComponentTag called.
>             component="+component+", tag="+tag);
>                   if (isEnabled(component)) {
>                     System.out.println("changing attribute, value="+value);
>                     tag.getAttributes().put(__attribute, value);
>                   }
>                 }
>
>             What is this construct trying to achieve, please? I don't
>             know this
>             method in Wicket 1.4 and in 6.0 the super class declares it
>             as final!
>             Once I know what's it's for, I'll be able to ask for help to
>             the Wicket
>             mailing-list.
>
>             Regards,
>
>             Pierre
>
>
>
>             On Thu, Apr 11, 2013 at 6:59 PM, ceki <ceki at qos.ch
>             <mailto:ceki at qos.ch> <mailto:ceki at qos.ch <mailto:ceki at qos.ch>>>
>
>             wrote:
>
>
>                  I am looking forward for your contribution.
>
>
>                  On 11.04.2013 18:38, Pierre Goupil wrote:
>
>                      Cheers Ceki! Keep in touch!
>
>                      Regards,
>
>                      Pierre
>
>

>


-- 
Ceki
65% of statistics are made up on the spot


More information about the mistletoe mailing list