[slf4j-dev] [Bug 62] jcl104-over-slf4j not recompiled with modified LocationAwareLogger

[bugzilla-daemon at pixie.qos.ch]

http://bugzilla.slf4j.org/show_bug.cgi?id=62


listid at qos.ch changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




------- Comment #1 from listid at qos.ch  2007-09-12 23:01 -------

I went and downloaded SLF4J 1.4.3 from http://www.slf4j.org. After
unarchiving jcl104-over-slf4j-1.4.3.jar with the command:

  jar xvf jcl104-over-slf4j-1.4.3.jar

and disassembling SLF4JLocationAwareLog with the command:

javap -c org.apache.commons.logging.impl.SLF4JLocationAwareLog >
SLF4JLocationAwareLog.txt

it looks like the folded constants in SLF4JLocationAwareLog have the
correct values.

For example, the info method in SLF4JLocationAwareLog.txt reads

public void info(java.lang.Object, java.lang.Throwable);
  Code:
   0:   aload_0
   1:   getfield        #7; //Field logger:Lorg/slf4j/spi/LocationAwareLogger;
   4:   aconst_null
   5:   getstatic       #13; //Field FQCN:Ljava/lang/String;
   8:   bipush  20   <=== 20 is the value of this line is correct
   10:  aload_1
   etc.

The value used for INFO_INT is 20 which is the correct value.

In short, ans as far as I can tell, the constants used in
SLF4JLocationAwareLog class shipping with SLF4J 1.4.3 is correct.

As such, I am closing this report as INVALID. I'd appreciate if you
could verify on your side and either reopen or verify this bug report
entry.


-- 
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.