[slf4j-dev] [Bug 76] Endless recursion in Marker. contains in case of recursive Marker hierarchy and Marker that is *not* contained .

[bugzilla-daemon at pixie.qos.ch]

http://bugzilla.slf4j.org/show_bug.cgi?id=76


Ceki Gulcu <listid at qos.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
                 CC|                            |listid at qos.ch
         Resolution|                            |FIXED




--- Comment #7 from Ceki Gulcu <listid at qos.ch>  2008-08-02 22:38:22 ---

Hi Joern,

Thank you for reopening this report. I agree with your point about
marker not necessarily being singletons. Consequently, in revision
1093, the BasicMarker.remove(Marker) and BasicMarker.contains(Marker)
methods have been modified to use equals() instead of ==.

The javadocs of add() method in the Marker interface now mentions that
IllegalArgumentException will be thrown for null argument values. See
revision 1094.

BasicMarker is supposed to be basic. It does not need to support
cycles. There is no use-case for it that I know of. When any user
finds and takes the time to describe a use-case, I'll reconsider. When
you say "[cyclical] nesting desired by the developer of an actual
application" do you have a use-case in mind? 

Please close this report bug if you agree and reopen if you do not.


-- 
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.