[slf4j-dev] svn commit: r1210 - slf4j/trunk/slf4j-api/src/test/java/org/slf4j/helpers

Thorbjørn Ravn Andersen ravn at runjva.com
Sat Oct 25 16:51:40 CEST 2008


Ralph Goers skrev:
> What Ceki is doing is an imperfect, but better approach than what you 
> are suggesting. The current approach adjusts its expectations based on 
> the baseline performance of the build machine. So as builds are done on 
> slower or faster hardware the expected baseline should change with it.
>   
Naturally you need to calibrate to the execution environment, in order 
to determine if a given test is "too slow".

As you may have noticed my suggestion is not changing the actual 
performance tests, but to change how the results are handled.

Right now it is a fatal error if a performance test is deemed too slow, 
causing the build to fail.    That is fine for the slf4j developer but I 
don't think it is right that it is mandatory for those who just would 
like to build from source.
 
Perhaps it is just a matter of making it a non-mandatory target?

/Thorbjørn



More information about the slf4j-dev mailing list