[slf4j-dev] [JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out

[QOS.CH (JIRA)]

    [ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18211#comment-18211 ] 

Ceki Gülcü commented on SLF4J-389:
----------------------------------

Hi [~michael-o]

Just had a look at [monkey patched slf4j-simple provider|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=94bc4de2ea54afa09a353034ed06edf0f68a8d87]

Wouldn't be easier of the renderThrowable and renderLevel method were already available in SimpleLogger? It's seems like a trivial change on this end.

> SimpleLogger caches System.err and System.out
> ---------------------------------------------
>
>                 Key: SLF4J-389
>                 URL: https://jira.qos.ch/browse/SLF4J-389
>             Project: SLF4J
>          Issue Type: Bug
>    Affects Versions: 1.7.x
>            Reporter: Igor Polevoy
>            Assignee: Ceki Gülcü
>             Fix For: 1.7.23
>
>
> We usually use SimpleLogger in tests, and some other binding when running  in production. 
> In some cases, our tests depend on log values logged through the logger during a test. 
> Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. 
> Here is the code that broke this approach: 
> https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890d4d5
> Basically, we would write a test: 
> {quote}PrintStream err = System.err; 
> PrintStream temp = new PrintStream(some buffer here);
> System.err = temp;
> // run tests
> System.err = err;
> // here we assert that the temp stream contains values we expect{quote}
> Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. 



--
This message was sent by Atlassian JIRA
(v7.3.1#73012)