[slf4j-dev] [qos-ch/slf4j] 27358d: Fix NOP fallback memory leak

Ceki Gulcu noreply at github.com
Tue Dec 10 08:51:07 CET 2019


  Branch: refs/heads/master
  Home:   https://github.com/qos-ch/slf4j
  Commit: 27358d395c8b1f47a9c13ca47bbff33e75dd1fa3
      https://github.com/qos-ch/slf4j/commit/27358d395c8b1f47a9c13ca47bbff33e75dd1fa3
  Author: David Harsha <davishmcclurg at gmail.com>
  Date:   2019-12-09 (Mon, 09 Dec 2019)

  Changed paths:
    M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java
    A slf4j-api/src/test/java/org/slf4j/NoBindingMultithreadedInitializationTest.java
    M slf4j-api/src/test/java/org/slf4j/testHarness/MultithreadedInitializationTest.java

  Log Message:
  -----------
  Fix NOP fallback memory leak

Substitute loggers are not getting "fixed" when no SLF4J provider is
found, which means `SUBST_PROVIDER` will add messages to its
`LinkedBlockingQueue` until the process runs out of memory.

`NoBindingMultithreadedInitializationTest` doesn't contain any
assertions of its own because `MultithreadedInitializationTest` already
asserts loggers are fixed in `assertAllSubstLoggersAreFixed`.

https://jira.qos.ch/browse/SLF4J-469


  Commit: 306d8fd23d89b0ad510172c7a15d10175efe691d
      https://github.com/qos-ch/slf4j/commit/306d8fd23d89b0ad510172c7a15d10175efe691d
  Author: Ceki Gulcu <ceki at qos.ch>
  Date:   2019-12-10 (Tue, 10 Dec 2019)

  Changed paths:
    M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java
    A slf4j-api/src/test/java/org/slf4j/NoBindingMultithreadedInitializationTest.java
    M slf4j-api/src/test/java/org/slf4j/testHarness/MultithreadedInitializationTest.java

  Log Message:
  -----------
  Merge pull request #228 from davishmcclurg/SLF4J-469

Fix NOP fallback memory leak


Compare: https://github.com/qos-ch/slf4j/compare/9a3f1f4928ab...306d8fd23d89


More information about the slf4j-dev mailing list