From slf4j-dev at qos.ch Fri Aug 4 07:29:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Fri, 4 Aug 2023 05:29:00 +0000 Subject: [slf4j-dev] Request to perform some cleanup in the source code Message-ID: Hello all I'm a Software Developer and I would like to contribute to an open source project and I think this one is a great one. My idea is to start with basic cleanup while I get familiarized with the code, deployment pipeline, etc. I mean no disrespect, I understand this project was created by amazing developers, I just want to contribute back to the java community. please let me know if you are open for this kind of contributions and what would be the next steps Regards From slf4j-dev at qos.ch Sun Aug 6 21:00:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Sun, 6 Aug 2023 21:00:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-437: Create a BOM POM In-Reply-To: References: Message-ID: SLF4J / SLF4J-437 [Resolved] Create a BOM POM ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-437 ============================== 1 comment ------------------------------ Garret Wilson on 06/Aug/23 20:49 [~ceki], I just realized that in my blog post I had neglected to add {{pom.xml}} to the {{parent-pom.xml}} file in the final approach. I looked at your commit and I think you left it out as well. It's probably a good idea to add it; if I remember correctly, Maven will default to trying to find {{pom.xml}} in the _parent_ directory if you leave it off. I've updated the blog post with this modification. Note that I also removed the {{}} and {{}} in the child POMs, as they are inherited and don't need to be specified again if they are the same as the parent. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Mon Aug 7 10:49:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Mon, 7 Aug 2023 10:49:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-437: Create a BOM POM In-Reply-To: References: Message-ID: SLF4J / SLF4J-437 [Resolved] Create a BOM POM ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-437 ============================== 1 comment ------------------------------ Ceki Gülcü on 07/Aug/23 10:38 [~garretwilson] Thank you for the updates. I would like to add that in the last variant, it is easy to miss that the BOM file, i.e in the top-most pom.xml file, needs to reference parent-pom.xml as a *module*. Otherwise, parent-pom.xml will not be installed into your repository. Given that an existing parent-pom might exist in the local repository due to past experiments, the problem might not be detected for a while, as happened with me. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Tue Aug 8 18:25:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Tue, 8 Aug 2023 18:25:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-529: Platform Logging bridge should use MessageFormat but it's using String.format In-Reply-To: References: Message-ID: SLF4J / SLF4J-529 [Resolved] Platform Logging bridge should use MessageFormat but it's using String.format ============================== Here's what changed in this issue in the last few minutes. There are 2 updates. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-529 ============================== 2 updates ------------------------------ Changes by Ceki Gülcü on 08/Aug/23 18:14 Resolution: Fixed Status: Resolved (was: Open) ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Tue Aug 8 18:25:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Tue, 8 Aug 2023 18:25:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-597: Fix typo in "SLF4JPlarformLoggerFactory" In-Reply-To: References: Message-ID: SLF4J / SLF4J-597 [Open] Fix typo in "SLF4JPlarformLoggerFactory" ============================== Here's what changed in this issue in the last few minutes. This issue has been created This issue is now assigned to you. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-597 ============================== Issue created ------------------------------ Ceki Gülcü created this issue on 08/Aug/23 18:24 Summary: Fix typo in "SLF4JPlarformLoggerFactory" Issue Type: Bug Affects Versions: 2.0.7 Assignee: SLF4J developers list Created: 08/Aug/23 18:24 Priority: Major Reporter: Ceki Gülcü ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Tue Aug 8 19:07:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Tue, 8 Aug 2023 19:07:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-598: SLF4JPlarformLoggerFactory In-Reply-To: References: Message-ID: SLF4J / SLF4J-598 [Open] SLF4JPlarformLoggerFactory ============================== Here's what changed in this issue in the last few minutes. This issue has been created This issue is now assigned to you. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-598 ============================== Issue created ------------------------------ Ethan McCue created this issue on 08/Aug/23 18:56 Summary: SLF4JPlarformLoggerFactory Issue Type: Improvement Affects Versions: 2.0.7 Assignee: SLF4J developers list Components: Implementations Created: 08/Aug/23 18:56 Priority: Trivial Reporter: Ethan McCue External issue URL: https://github.com/qos-ch/slf4j/pull/354 Priority: P5 Severity: trivial Description: SLF4JPla{*}r{*}formLoggerFactory should probably be named SLF4JPlatformLoggerFactory for english reasons. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Tue Aug 8 22:29:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Tue, 8 Aug 2023 22:29:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-597: Fix typo in "SLF4JPlarformLoggerFactory" In-Reply-To: References: Message-ID: SLF4J / SLF4J-597 [Resolved] Fix typo in "SLF4JPlarformLoggerFactory" ============================== Here's what changed in this issue in the last few minutes. There are 2 updates. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-597 ============================== 2 updates ------------------------------ Changes by Ceki Gülcü on 08/Aug/23 22:20 Resolution: Duplicate Status: Resolved (was: Open) ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Tue Aug 8 22:29:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Tue, 8 Aug 2023 22:29:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-598: SLF4JPlarformLoggerFactory In-Reply-To: References: Message-ID: SLF4J / SLF4J-598 [Resolved] SLF4JPlarformLoggerFactory ============================== Here's what changed in this issue in the last few minutes. There are 2 updates. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-598 ============================== 2 updates ------------------------------ Changes by Ceki Gülcü on 08/Aug/23 22:18 Resolution: Fixed Status: Resolved (was: Open) ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Wed Aug 9 17:34:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Wed, 9 Aug 2023 17:34:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-437: Create a BOM POM In-Reply-To: References: Message-ID: SLF4J / SLF4J-437 [Resolved] Create a BOM POM ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-437 ============================== 1 comment ------------------------------ Garret Wilson on 09/Aug/23 17:22 [~ceki], there may be another wrinkle here. Do you by any chance use Eclipse with m2e (the Maven support for Eclipse)? I just released a new version of a utility library {{com.globalmentor:globalmentor-base:0.7.4}} using this technique of having {{pom.xml}} and {{parent-pom.xml}} in the same directory (rather than having the parent POM in {{parent/pom.xml}}. This seems to have confused m2e with other libraries that use {{globalmentor-base}}. I'm worried whether this approach will cause problems with tools, even though Maven is fine with it. If I don't hear back from the m2e team, I may have to switch back to the {{parent/pom.xml}} approach and republish my own libraries. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Wed Aug 9 22:38:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Wed, 9 Aug 2023 22:38:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-599: simplistic migration In-Reply-To: References: Message-ID: SLF4J / SLF4J-599 [Open] simplistic migration ============================== Here's what changed in this issue in the last few minutes. This issue has been created This issue is now assigned to you. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-599 ============================== Issue created ------------------------------ delanym created this issue on 09/Aug/23 22:26 Summary: simplistic migration Issue Type: Bug Affects Versions: 2.0.7 Assignee: SLF4J developers list Components: slf4j-migrator Created: 09/Aug/23 22:26 Priority: Major Reporter: Delany Middleton Description: The migrator seems to be using a string replace methodology, instead of parsing the code and replacing tokens. Kind of frightening. For example {code:java} -    headerDisplay.setValue("Service Processor Log Information"); +    headerDisplay.setValue("Service Processor Logger Information");{code}   ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Thu Aug 10 00:02:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Thu, 10 Aug 2023 00:02:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-437: Create a BOM POM In-Reply-To: References: Message-ID: SLF4J / SLF4J-437 [Resolved] Create a BOM POM ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-437 ============================== 1 comment ------------------------------ Garret Wilson on 09/Aug/23 23:50 {quote}This seems to have confused m2e …{quote} After further investigation this may be an m2e bug introduced into a 2.4.x snapshot version; it is not clear if it is related to the POM structure. I'm discussing this with the m2e team and I'll keep you updated. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Thu Aug 17 11:58:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Thu, 17 Aug 2023 11:58:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-579: Export slf4j packages in version 1 and 2 in OSGi-Manifests In-Reply-To: References: Message-ID: SLF4J / SLF4J-579 [Resolved] Export slf4j packages in version 1 and 2 in OSGi-Manifests ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-579 ============================== 1 comment ------------------------------ Konrad Windszus on 17/Aug/23 11:47 @Ceki Gülcü Do you reconsider the decision to only export org.slf4j.helpers in incompatible version 2.x for SLF4J 2.x? Otherwise making an OSGi bundle using SLF4J will be a lot harder to make compatible both with SLF4J 2.x and 1.x..... ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Tue Aug 22 15:48:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Tue, 22 Aug 2023 15:48:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-579: Export slf4j packages in version 1 and 2 in OSGi-Manifests In-Reply-To: References: Message-ID: SLF4J / SLF4J-579 [Reopened] Export slf4j packages in version 1 and 2 in OSGi-Manifests ============================== Here's what changed in this issue in the last few minutes. There are 2 updates, 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-579 ============================== 2 updates ------------------------------ Changes by Ceki Gülcü on 22/Aug/23 15:46 Resolution: (was: Fixed) Status: Reopened (was: Resolved) ============================== 1 comment ------------------------------ Ceki Gülcü on 22/Aug/23 15:37 [~kwin] Marking org.slf4j.helpers package as compatible bith both 1.7.x and 2.x seems somewhat dishonest. Indeed, actual compatibility would be the result of luck. Moreover, There were a fair amount of classes in the org.slf4j.helpers package that were changed during the development of the 2.x series. If compatibility was preserved, then that would be the result of luck. Thus, it seems some what dishonest to mark the org.slf4j.helpers package as compatible with both 1.7.x and 2.0.x. However, if that is the wish of the OSGi community, then I won't stand in the way. I propose to incorporate the suggested changed but to mark them as "provisional" in case it impacts other users. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Tue Aug 22 16:22:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Tue, 22 Aug 2023 16:22:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-579: Export slf4j packages in version 1 and 2 in OSGi-Manifests In-Reply-To: References: Message-ID: SLF4J / SLF4J-579 [Reopened] Export slf4j packages in version 1 and 2 in OSGi-Manifests ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-579 ============================== 1 comment ------------------------------ Konrad Windszus on 22/Aug/23 16:11 bq. If compatibility was preserved, then that would be the result of luck. Thus, it seems some what dishonest to mark the org.slf4j.helpers package as compatible with both 1.7.x and 2.0.x. This contradicts what is written in https://www.slf4j.org/faq.html#compatibility (which doesn't mention restrictions for certain packages). Can you clarify what you are committing to with regards to backwards-compatibility? I agree marking it as backwards compatible should only be done in case this is automatically checked (e.g. with https://github.com/bndtools/bnd/tree/master/maven-plugins/bnd-baseline-maven-plugin) and this is kept for all 2.x versions. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Wed Aug 23 16:41:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Wed, 23 Aug 2023 16:41:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-437: Create a BOM POM In-Reply-To: References: Message-ID: SLF4J / SLF4J-437 [Resolved] Create a BOM POM ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-437 ============================== 1 comment ------------------------------ Garret Wilson on 23/Aug/23 16:30 Good morning, [~ceki]. I have good news and not-so-good news. It turns out that [m2e-core Issue #1501|https://github.com/eclipse-m2e/m2e-core/issues/1501], in which Eclipse Maven support wasn't correctly resolving dependencies, turned out to be a bug they introduced into the latest development version. It had nothing to do with the BOM POM structure. It only seemed related because that's what I had been changing when I discovered the new dependency calculation bug. (For what it's worth, they just committed a fix for that bug.) The not-so-good is that the [Nexus Staging Maven Plugin|https://github.com/sonatype/nexus-maven-plugins/blob/main/staging/maven-plugin/README.md] seems to have a bug that makes it not deploy the top-level POM if another POM is at the same directory level. Thus the structure we were using with the {{parent-pom.xml}} file in the root of the project alongside {{pom.xml}} will cause {{pom.xml}} not to be deployed!!! I filed bug [{{MVNCENTRAL-8292}}|https://issues.sonatype.org/browse/MVNCENTRAL-8292], but I may have to file another ticket for the Nexus Staging Maven Plugin. I don't know the likelihood of it being fixed though; we'll have to see. In the meantime, we'll have to move {{parent-pom.xml}} back into {{parent/pom.xml}}. Don't forget 1) to update the aggregation to say {{parent}}, 2) to remove the {{pom.xml}} inside {{parent/pom.xml}}, and 3) to change the other POMs from {{../parent-pom.xml}} to {{../parent/pom.xml}}. In other words, we'll have to follow the second-to-last structure in my BOM article. I only just now updated [{{MVNCENTRAL-8292}}|https://issues.sonatype.org/browse/MVNCENTRAL-8292] with this latest discovery, so it's possible they could quickly fix this in the Nexus Staging Maven Plugin. In the meantime I'm going to redeploy my {{globalmentor-base}} and {{globalmentor-web}} projects as described in this comment so they wont' be broken. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Thu Aug 24 22:21:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Thu, 24 Aug 2023 22:21:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-437: Create a BOM POM In-Reply-To: References: Message-ID: SLF4J / SLF4J-437 [Resolved] Create a BOM POM ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-437 ============================== 1 comment ------------------------------ Ceki Gülcü on 24/Aug/23 22:10 [~garretwilson] Thank you very much for your update. It is highly appreciated. SLF4J uses the maven-deploy-plugin to deploy to Maven Central. I hope to cut an SLF4J release tomorrow and will keep you posted. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Fri Aug 25 12:39:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Fri, 25 Aug 2023 12:39:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-579: Export slf4j packages in version 1 and 2 in OSGi-Manifests In-Reply-To: References: Message-ID: SLF4J / SLF4J-579 [Reopened] Export slf4j packages in version 1 and 2 in OSGi-Manifests ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-579 ============================== 1 comment ------------------------------ Ceki Gülcü on 25/Aug/23 12:28 [~kwin] I modified the FAQ [entry |https://www.slf4j.org/faq.html#compatibility] to make the language clearer. The entry now specifically mentions the {{org.slf4j}} package. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Tue Aug 29 14:57:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Tue, 29 Aug 2023 14:57:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-592: Mechanism for indicating provider to use for unit tests. In-Reply-To: References: Message-ID: SLF4J / SLF4J-592 [Resolved] Mechanism for indicating provider to use for unit tests. ============================== Here's what changed in this issue in the last few minutes. There are 2 updates, 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-592 ============================== 2 updates ------------------------------ Changes by Ceki Gülcü on 29/Aug/23 14:46 Resolution: Duplicate Status: Resolved (was: Open) ============================== 1 comment ------------------------------ Ceki Gülcü on 29/Aug/23 14:47 Closing as duplicate of SLF4J-450 ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af) From slf4j-dev at qos.ch Thu Aug 31 23:24:00 2023 From: slf4j-dev at qos.ch (slf4j developers list) Date: Thu, 31 Aug 2023 23:24:00 +0200 (CEST) Subject: [slf4j-dev] [JIRA] Updates for SLF4J-579: Export slf4j packages in version 1 and 2 in OSGi-Manifests In-Reply-To: References: Message-ID: SLF4J / SLF4J-579 [Reopened] Export slf4j packages in version 1 and 2 in OSGi-Manifests ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-579 ============================== 1 comment ------------------------------ Hannes Wellmann on 31/Aug/23 23:12 > I agree marking it as backwards compatible should only be done in case this is automatically checked (e.g. with [https://github.com/bndtools/bnd/tree/master/maven-plugins/bnd-baseline-maven-plugin]) and this is kept for all 2.x versions.   [~kwin] you could use the bnd-baseline-maven-plugin to check if the org.slf4j.helpers plugin is backwards compatible by using slf4j 1.7.36 as baseline? Nevertheless having tooling to ensure backwards compatibility (or actually correctly applied semantic versioning) would be helpful in case something is overseen. ============================== This message was sent by Atlassian Jira (v9.6.0#960000-sha1:a3ee8af)