[slf4j-user] Javadoc for LocationAwareLogger seems wrong

Woonsan Ko woon_san at yahoo.com
Sat Jul 23 04:51:03 CEST 2011


I realized that LocationAwareLogger#log() method was changed since 1.6.x with 
additional Object [] argument between msg and throwable.
However, the implementation such as log4j impl has not ever used that argument 
yet.
It seems the implementation would do message formatting in the future, but 
anyway, the javadoc doesn't mention the new argument yet.
Please update the javadoc.

Regards,

Woonsan


----- Original Message ----
> From: Woonsan Ko <woon_san at yahoo.com>
> To: slf4j-user at qos.ch
> Sent: Fri, July 22, 2011 2:21:35 PM
> Subject: Javadoc for LocationAwareLogger seems wrong
> 
> Hi,
> 
> I found a difference between javadoc [1] and source code of  
>LocationAwareLogger 
>
> [2]:
> 
> [javadoc]
> public void log(Marker marker,  String fqcn, int level, String message, 
>Object[] 
>
> argArray, Throwable t) 
> 
> [source]
> public void log(Marker marker, String fqcn, int level,  String message, 
>Throwable 
>
> t);
> 
> Guess javadoc should be  regenerated.
> 
> Regards,
> 
> Woonsan
> 
> [1]  http://www.slf4j.org/api/org/slf4j/spi/LocationAwareLogger.html
> [2]  
>http://svn.slf4j.org/viewvc/slf4j/trunk/slf4j-api/src/main/java/org/slf4j/spi/LocationAwareLogger.java?view=markup
>
> 
> 


More information about the slf4j-user mailing list