[logback-dev] svn commit: r2142 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j

[Thorbjørn Ravn Andersen]

noreply.ceki at qos.ch skrev:
> Author: ceki
> Date: Wed Feb  4 22:51:17 2009
> New Revision: 2142
>
> Added:
>    logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j/
>    logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j/XMLLayout.java
>
> Log:
> Starting work on LBCLASSIC-22
>
> This is an initial implementation based on my previous work on log4j.
>
> Added: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j/XMLLayout.java
> ==============================================================================
> --- (empty file)
> +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j/XMLLayout.java	Wed Feb  4 22:51:17 2009
> @@ -0,0 +1,131 @@
> +/**
> + * Logback: the generic, reliable, fast and flexible logging framework.
> + * 
> + * Copyright (C) 2000-2009, QOS.ch
> + * 
> + * This library is free software, you can redistribute it and/or modify it under
> + * the terms of the GNU Lesser General Public License as published by the Free
> + * Software Foundation.
> + */
> +package ch.qos.logback.classic.log4j;
> +
> +import ch.qos.logback.classic.spi.CallerData;
> +import ch.qos.logback.classic.spi.LoggingEvent;
> +import ch.qos.logback.classic.spi.ThrowableDataPoint;
> +import ch.qos.logback.classic.spi.ThrowableProxy;
> +import ch.qos.logback.core.LayoutBase;
> +import ch.qos.logback.core.helpers.Transform;
> +
> +// Code is based on revision 309623 of org.apache.log4j.xml.XMLLayout dated "Wed
> +// Jul 31 09:25:14 2002 UTC" as authored by Ceki Gulcu.
> +// See also http://tinyurl.com/dch9mr
> +
> +/**
> + * 
> + * Generates log4j.dtd compliant XML documents.
> + * 
> + * 
> + * @author Ceki Gülcü
> + * @author Thorbj�rn Ravn Andersen
>   
Hi.

Is there any reason you didn't just take the XMLLayout.java I 
contributed to the JIRA case and put in?

The XML generated is suitable for human reading, is 7-bit clean and 
includes a human readable time value?

As it is now, I see no reason what so ever that you put my name on the 
authors list :(


-- 
  Thorbjørn Ravn Andersen  "...plus... Tubular Bells!"